Skip to content

Conversation

@souro26
Copy link

@souro26 souro26 commented Jan 19, 2026

This PR addresses #812 by correcting the docstring of build_model in the
ModelBuilder example notebook.

Specifically, it removes the incorrect reference to model_config as a
function parameter and clarifies that model configuration is accessed via
self.model_config, which is provided by the base ModelBuilder class.

No runtime or behavioral changes are introduced. The notebook was run
end-to-end on a fresh kernel after the update.

Closes #812

Helpful links

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing docstrings in ModelBuilder Example

1 participant