Skip to content

Conversation

ricardoV94
Copy link
Member

No description provided.

@ricardoV94 ricardoV94 requested a review from maresb October 4, 2024 07:29
@maresb
Copy link
Collaborator

maresb commented Oct 4, 2024

As a PR this confuses me because it seemingly does two seemingly unrelated things:

  1. Fix the CI
  2. Update the version number in preparation for a release

You might consider updating the PR title. And then as soon as it's merged, so that we don't forget, consider immediately creating a (currently-failing) PR to unpin micromamba.

@ricardoV94
Copy link
Member Author

ricardoV94 commented Oct 4, 2024

The goal is to do a release, it happens that the CI is failing, so we pinned. They are separate commits and the PR itself won't show up in the release notes. I'll open the issue to unpin micromamba once we merge and I can reference the commit.

@ricardoV94 ricardoV94 changed the title Update version.txt Update version (pin failing micromamba) Oct 4, 2024
@ricardoV94 ricardoV94 changed the title Update version (pin failing micromamba) Update version (and pin failing micromamba) Oct 4, 2024
Copy link
Collaborator

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying, sounds good!

Last week I had an incident where I cut a release, and the behavior changed in an unexpected way. I spent a long time scouring my PR titles for a potential explanation, and had to do a painstaking bisection. The culprit was a PR where I made an incidental fix that obviously resulted in the change, but I forgot to note this anywhere. So at the moment I'm a bit jumpy about this stuff. 😂

@ricardoV94
Copy link
Member Author

Thanks for clarifying, sounds good!

Last week I had an incident where I cut a release, and the behavior changed in an unexpected way. I spent a long time scouring my PR titles for a potential explanation, and had to do a painstaking bisection. The culprit was a PR where I made an incidental fix that obviously resulted in the change, but I forgot to note this anywhere. So at the moment I'm a bit jumpy about this stuff. 😂

My policy is unrelated changes can go in the same PR as long as they are in separate clean commits and we don't have to squash merge. Otherwise they must go on separate PRs. In this case it seemed silly to run the CI twice as well

@ricardoV94 ricardoV94 merged commit db36290 into main Oct 4, 2024
7 checks passed
@maresb
Copy link
Collaborator

maresb commented Oct 4, 2024

Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants