Skip to content

remove lbfgs logger.warning #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+0 −2
Closed

remove lbfgs logger.warning #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pymc_extras/inference/pathfinder/lbfgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ def minimize(self, x0) -> tuple[NDArray, NDArray, int, LBFGSStatus]:
# threshold determining if the number of update mask is low compared to iterations
low_update_threshold = 3

logging.warning(f"LBFGS status: {result} \n nit: {result.nit} \n count: {history.count}")

if history.count <= 1: # triggers LBFGSInitFailed
if result.nit < low_update_threshold:
lbfgs_status = LBFGSStatus.INIT_FAILED
Expand Down
Loading