Skip to content

Conversation

jessegrabowski
Copy link
Member

Scikit-learn 1.7.0 wants all LinearModel estimators to also have a BaseEstimator mixin to the far right. This is currently raising a DepreciationWarning, but will switch to an error at some point.

Copy link
Contributor

@zaxtax zaxtax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does this mean we need to bump up the minimum scikit-learn we support?

@jessegrabowski
Copy link
Member Author

No, we don't pin it currently. I think that's why tests were failing in #517

As far as I can tell, it shouldn't cause any backward compat problems

@jessegrabowski jessegrabowski merged commit c35bc67 into pymc-devs:main Jun 13, 2025
17 checks passed
andreacate pushed a commit to andreacate/pymc-extras that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants