Respect include_transformed argument of find_MAP and fit_laplace #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
changed the title
ricardoV94
approved these changes
Jul 10, 2025
andreacate
pushed a commit
to andreacate/pymc-extras
that referenced
this pull request
Jul 22, 2025
andreacate
pushed a commit
to andreacate/pymc-extras
that referenced
this pull request
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #531 I forgot to handle the
include_transformedoption in find_MAP and fit_laplace. @tomicapretto found that setting it to False causes an error.After this PR, if
include_transformed=False, theunconstrained_posteriorgroup won't be calculated or included.