Pass model to add_fit_to_inference_data
#538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jul 17, 2025
| @@ -336,7 +336,7 @@ def find_MAP( | |||
| } | |||
|
|
|||
| idata = map_results_to_inference_data(optimized_point, frozen_model, include_transformed) | |||
| idata = add_fit_to_inference_data(idata, raveled_optimized, H_inv) | |||
| idata = add_fit_to_inference_data(idata, raveled_optimized, H_inv, model) | |||
There was a problem hiding this comment.
To avoid name confusion?
Suggested change
| idata = add_fit_to_inference_data(idata, raveled_optimized, H_inv, model) | |
| idata = add_fit_to_inference_data(idata, raveled_optimized, H_inv, model=model) |
|
Fixed in #543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this find_map only works when called inside a model context, otherwise this step has no access to the model object