maintenance of statespace notebooks #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k_checks merge upstream
…r latest changes made to state space and updated SARIMAX sigma shape specification to be consistent with statespace structural
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB AlexAndorra commented on 2025-07-31T21:35:20Z Line #36. # I think here you want to use the forecast index instead due to missing value imputation Need to remove this comment |
AlexAndorra
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Looks great @Dekermanjian , thanks a lot! I just left a comment in the ETS NB. Please make sure the tests pass, and then I'll merge. LMK if you have any questions!
|
Thank you, Alex! I went ahead and removed the lingering comments I made in the code. I tested locally and everything passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the statespace notebooks:
and made sure that first there are no breakages that lead to error outputs but also updated specific parts that are going to be deprecated in the future like how/when
mode="JAX"is being used.I also updated the shape of the sigma parameter specified by the SARIMAX implementation where it was returning a shape of
Noneinstead of()for a scalarThis is related to issue #553