Numba backend for Pathfinder #565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're implementing way too much stuff. All the contiguous matmul stuff... why? Numba is capable of doing that much better and will dispatch to blas... which you want to do. What was the old pathfinder doing and why can't you just compile PyTensor stuff to numba? |
|
OK, I figured we wanted to use PyTensor where possible. Back to the drawing board! |
Yes we do, but you shouldn't have to implement any new Ops, like you were doing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at using Numba with Pathfinder. It works, but is not yet performant (order of magnitude slower at the moment).