Skip to content

Conversation

@Armavica
Copy link
Member

@Armavica Armavica commented Nov 4, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify): CI

📚 Documentation preview 📚: https://pymc--7558.org.readthedocs.build/en/7558/

@Armavica Armavica added Github CI/CD no releasenotes Skipped in automatic release notes generation labels Nov 4, 2024
@ricardoV94 ricardoV94 requested a review from maresb November 4, 2024 14:14
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (3057351) to head (6ebc075).
Report is 87 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7558   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         106      106           
  Lines       17669    17669           
=======================================
  Hits        16403    16403           
  Misses       1266     1266           

Copy link

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement if you want to preempt running jobs when you push a new commit to a PR, especially if workflows run for a long time.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Armavica! I was a bit confused since I believed this was the default behavior, but it turns out instead that most repos I work with already have this set. Good catch!

@maresb
Copy link
Contributor

maresb commented Nov 15, 2024

@ricardoV94 I think this is ready when you are

@ricardoV94 ricardoV94 merged commit 36cca5b into pymc-devs:main Nov 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Github CI/CD no releasenotes Skipped in automatic release notes generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants