Skip to content

fix: deep copy nuts_sampler_kwarg to prevent .pop side effects #7652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2025
Merged

fix: deep copy nuts_sampler_kwarg to prevent .pop side effects #7652

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caa9501
fix: deep copy nuts_sampler_kwarg to prevent pop side effects
inclinedadarsh Jan 20, 2025
e6c5b1a
fix: replace deep copy with shalow copy
inclinedadarsh Jan 20, 2025
4db8ed6
fix: remove unnecessary shallow copy
inclinedadarsh Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions pymc/sampling/mcmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,11 @@ def _sample_external_nuts(
nuts_sampler_kwargs: dict | None,
**kwargs,
):
if nuts_sampler_kwargs is None:
nuts_sampler_kwargs = {}
import copy

nuts_sampler_kwargs_copy = copy.deepcopy(nuts_sampler_kwargs)
if nuts_sampler_kwargs_copy is None:
nuts_sampler_kwargs_copy = {}

if sampler == "nutpie":
try:
Expand Down Expand Up @@ -339,8 +342,8 @@ def _sample_external_nuts(
)
compile_kwargs = {}
for kwarg in ("backend", "gradient_backend"):
if kwarg in nuts_sampler_kwargs:
compile_kwargs[kwarg] = nuts_sampler_kwargs.pop(kwarg)
if kwarg in nuts_sampler_kwargs_copy:
compile_kwargs[kwarg] = nuts_sampler_kwargs_copy.pop(kwarg)
compiled_model = nutpie.compile_pymc_model(
model,
**compile_kwargs,
Expand All @@ -354,7 +357,7 @@ def _sample_external_nuts(
target_accept=target_accept,
seed=_get_seeds_per_chain(random_seed, 1)[0],
progress_bar=progressbar,
**nuts_sampler_kwargs,
**nuts_sampler_kwargs_copy,
)
t_sample = time.time() - t_start
# Temporary work-around. Revert once https://github.com/pymc-devs/nutpie/issues/74 is fixed
Expand Down Expand Up @@ -406,7 +409,7 @@ def _sample_external_nuts(
nuts_sampler=sampler,
idata_kwargs=idata_kwargs,
compute_convergence_checks=compute_convergence_checks,
**nuts_sampler_kwargs,
**nuts_sampler_kwargs_copy,
)
return idata

Expand Down Expand Up @@ -686,6 +689,9 @@ def sample(
mean sd hdi_3% hdi_97%
p 0.609 0.047 0.528 0.699
"""
import copy

nuts_sampler_kwargs_copy = copy.deepcopy(nuts_sampler_kwargs)
if "start" in kwargs:
if initvals is not None:
raise ValueError("Passing both `start` and `initvals` is not supported.")
Expand All @@ -695,8 +701,8 @@ def sample(
stacklevel=2,
)
initvals = kwargs.pop("start")
if nuts_sampler_kwargs is None:
nuts_sampler_kwargs = {}
if nuts_sampler_kwargs_copy is None:
nuts_sampler_kwargs_copy = {}
if "target_accept" in kwargs:
if "nuts" in kwargs and "target_accept" in kwargs["nuts"]:
raise ValueError(
Expand Down Expand Up @@ -808,7 +814,7 @@ def joined_blas_limiter():
progressbar=progressbar,
idata_kwargs=idata_kwargs,
compute_convergence_checks=compute_convergence_checks,
nuts_sampler_kwargs=nuts_sampler_kwargs,
nuts_sampler_kwargs=nuts_sampler_kwargs_copy,
**kwargs,
)

Expand Down
Loading