Skip to content

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented May 24, 2025

Description

Remove the duplicated logic for calculating speed and unit

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7801.org.readthedocs.build/en/7801/

@williambdean
Copy link
Contributor Author

what's up with the mypy. That is working locally for me. Maybe I need to update my versions

Copy link

codecov bot commented May 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (c8d83ca) to head (095d448).
⚠️ Report is 55 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7801      +/-   ##
==========================================
+ Coverage   92.84%   92.87%   +0.02%     
==========================================
  Files         107      107              
  Lines       18380    18373       -7     
==========================================
- Hits        17065    17064       -1     
+ Misses       1315     1309       -6     
Files with missing lines Coverage Δ
pymc/util.py 83.00% <100.00%> (+1.18%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94
Copy link
Member

It's new numpy type hints stuff, I was putting some ignores in my PR to bump PyTensor that's still open

@williambdean
Copy link
Contributor Author

Alright. Let me know if I need to adjust anything in this PR...

@williambdean
Copy link
Contributor Author

Ping

@ricardoV94 ricardoV94 added maintenance no releasenotes Skipped in automatic release notes generation labels Jun 15, 2025
@ricardoV94 ricardoV94 merged commit 3b62f82 into pymc-devs:main Jun 15, 2025
24 of 25 checks passed
@ricardoV94
Copy link
Member

Thanks @williambdean

@williambdean williambdean deleted the remove-duplicate-sampling-speed branch June 15, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance no releasenotes Skipped in automatic release notes generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused compute_draw_speed

2 participants