Advanced sub tensor with none and integers fix #7814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ricardoV94
requested changes
Jun 9, 2025
| a_val = a.type() | ||
| a_val.name = "a_val" | ||
|
|
||
| try: |
| if any( | ||
| indices.dtype.startswith("int") and sum(1 - b for b in indices.type.broadcastable) > 0 | ||
| for indices in mixing_indices | ||
| if not isinstance(indices, SliceConstant) |
There was a problem hiding this comment.
Suggested change
| if not isinstance(indices, SliceConstant) | |
| if not isinstance(indices.type, SliceType | NoneTypeT) |
|
Hi @golocule , are you still working on this ? If not, would you mind if I take it over ? Thank you 🙏 |
|
Fixed by #7877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the AdvancedSubTensor with None and Integer values bug of having a logprob error instead of gracefully crashing through including a check for NoneConst types in mixture.py. None is returned if None values are found in a logprob. Added a test in test_mixture.py called test_advanced_subtensor_none_and_integer that validates the bug is fixed through checking there is a runtime error instead of an internal error when a logprob dictionary of integers and None values is attempted to be created.
Related Issue
AdvancedSubTensorwithNoneand integer indices raises alogproberror instead of silently failing #7762Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7814.org.readthedocs.build/en/7814/