Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 27, 2025


📚 Documentation preview 📚: https://pymc--7876.org.readthedocs.build/en/7876/

@ricardoV94 ricardoV94 added pytensor no releasenotes Skipped in automatic release notes generation dependencies Pull requests that update a dependency file labels Jul 27, 2025
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (dc7cfee) to head (23905b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7876      +/-   ##
==========================================
+ Coverage   88.25%   92.94%   +4.69%     
==========================================
  Files         116      116              
  Lines       18845    18845              
==========================================
+ Hits        16631    17516     +885     
+ Misses       2214     1329     -885     
Files with missing lines Coverage Δ
pymc/distributions/continuous.py 98.25% <100.00%> (ø)
pymc/logprob/linalg.py 93.61% <100.00%> (ø)
pymc/ode/utils.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 59176b6 into pymc-devs:main Jul 28, 2025
26 checks passed
@asifzubair
Copy link
Contributor

Hi @ricardoV94 !

This might be a me-problem, but after this PR was merged I started having problems with my docker environment. I rebuilt the image and checked the pytensor version inside the image and it was 2.31, even though the requirements clearly are for 2.32.

I think the offending bit in the Dockerfile is:

RUN mamba env create -f environment-dev.yml && \
    /bin/bash -c ". activate pymc-dev && \
    mamba install -c conda-forge -y pymc" && \ # <=== here
    conda clean --all -f -y

I think the mamba installation from the conda-forge channel might be downgrading pytensor. In the end, I changed the DockerFile to this:

RUN mamba env create -f conda-envs/environment-dev.yml && \
    /bin/bash -c ". activate pymc-dev && \
    mamba install -y setuptools && \
    pip install --no-deps -e ." && \
    conda clean --all -f -y

The mamba install -y setuptools is necessary because otherwise the distutils dependency wasn't being met.

I don't think my fix is ideal (or even necessary), but just wanted to bring it up. I can start an issue, if you think we want to track this. Please let me know. Thanks! 🙏

@ricardoV94
Copy link
Member Author

Could it be that the pytensor/pymc release wasn't on conda yet? It takes sometime to get released

@ricardoV94 ricardoV94 deleted the bump_pytensor_dep branch July 29, 2025 09:48
@asifzubair
Copy link
Contributor

Yes, that might as well explain it. I'll re-build the image at the end of the week and let you know if it does/doesn't succeed. Thanks, again! :)

@asifzubair
Copy link
Contributor

Hi @ricardoV94 , just fyi, I rebuilt the docker image and checked the pytensor version today. It still seems to be at 2.31:

% bash scripts/docker_container.sh build
[+] Building 377.2s (11/11) FINISHED                                                                                                       docker:desktop-linux
 => [internal] load build definition from Dockerfile                                                                                                       0.0s
 => => transferring dockerfile: 895B                                                                                                                       0.0s
 => [internal] load .dockerignore                                                                                                                          0.0s
 => => transferring context: 57B                                                                                                                           0.0s
 => [internal] load metadata for docker.io/jupyter/base-notebook:python-3.9.12                                                                             0.9s
 => [internal] load build context                                                                                                                          0.0s
 => => transferring context: 82B                                                                                                                           0.0s
 => CACHED [1/6] FROM docker.io/jupyter/base-notebook:python-3.9.12@sha256:73acac537540c78c66bd9bb8d14b253bbb080dd569d5f83e1beba6e11ea69529                0.0s
 => [2/6] COPY /conda-envs/environment-dev.yml .                                                                                                           0.0s
 => [3/6] RUN mamba env create -f environment-dev.yml &&     /bin/bash -c ". activate pymc-dev &&     mamba install -c conda-forge -y pymc" &&     cond  304.9s
 => [4/6] RUN pip install --upgrade --user setuptools==58.3.0                                                                                              5.9s
 => [5/6] WORKDIR /home/jovyan/work                                                                                                                        0.0s 
 => [6/6] RUN echo "conda activate pymc-dev" >> ~/.bashrc &&     source ~/.bashrc                                                                          0.2s 
 => exporting to image                                                                                                                                    64.9s 
 => => exporting layers                                                                                                                                   64.9s 
 => => writing image sha256:a62b13feb4c40de658eef98512fbc8b93128745508de6370c4ece5e2c1d4c7da                                                               0.0s 
 => => naming to docker.io/library/pymc                                                                                                                    0.0s

What's Next?
  View a summary of image vulnerabilities and recommendations → docker scout quickview
%
% bash scripts/docker_container.sh bash 
(pymc-dev) jovyan@9aeedad7eb9b:~/work$ python
Python 3.13.5 | packaged by conda-forge | (main, Jun 16 2025, 08:27:50) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pytensor as pt
>>> pt.__version__
'2.31.7'
>>> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file no releasenotes Skipped in automatic release notes generation pytensor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants