-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Implement logcdf
for CensoredRV
#7884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logcdf
for CensoredRV
#7884
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main pymc-devs/pymc#7884 +/- ##
=======================================
Coverage 92.94% 92.95%
=======================================
Files 116 116
Lines 18845 18863 +18
=======================================
+ Hits 17516 17534 +18
Misses 1329 1329
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, just a comment about make the test more obviously correct
Thank you, @ricardoV94 ! I've addressed the comments now. Can you please have a look when you have a moment ? Thank you! 🙏 |
logcdf
for CensoredRV
logcdf
for CensoredRV
Description
We implement
logcdf
forCensoredRV
.Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7884.org.readthedocs.build/en/7884/