Skip to content

refactor: move _precition_mv_normal_logp into a seperate function #7895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Michal-Novomestsky
Copy link

@Michal-Novomestsky Michal-Novomestsky commented Aug 11, 2025

Addresses #7894 as part of pymc-devs/pymc-extras#532


📚 Documentation preview 📚: https://pymc--7895.org.readthedocs.build/en/7895/

Copy link

welcome bot commented Aug 11, 2025

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@ricardoV94
Copy link
Member

Let's duplicate it in pymc-extras first to see if we really need it refactored. In theory you should be able to introduce a PrecisionMVNormal RV and call logp on it to get this implementation. Anyway it will be more obvious if we need the refactor once the dependent work on pymc-extras is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants