Skip to content

Conversation

tomicapretto
Copy link
Contributor

@tomicapretto tomicapretto commented Sep 17, 2025

This PR adds var_names to the call to pm.sample_prior_predictive in mock_sample.
I'm looking forward to speed up tests in Bambi, which uses var_names under the hood.


📚 Documentation preview 📚: https://pymc--7906.org.readthedocs.build/en/7906/

@williambdean
Copy link
Contributor

Test failures seem unrelated...
But additions look good

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.62%. Comparing base (9f653a6) to head (7a3db78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7906      +/-   ##
==========================================
- Coverage   92.94%   91.62%   -1.33%     
==========================================
  Files         116      116              
  Lines       18851    18852       +1     
==========================================
- Hits        17522    17274     -248     
- Misses       1329     1578     +249     
Files with missing lines Coverage Δ
pymc/testing.py 90.00% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessegrabowski jessegrabowski merged commit 340e403 into pymc-devs:main Sep 23, 2025
65 of 81 checks passed
@tomicapretto
Copy link
Contributor Author

Thanks @williambdean @jessegrabowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants