Skip to content

Conversation

@zaxtax
Copy link
Contributor

@zaxtax zaxtax commented Oct 4, 2025

Description

Adds support for the Dirichlet distributions in pymc.dims

Related Issue

This depends on pymc-devs/pytensor#1629 to get merged

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7921.org.readthedocs.build/en/7921/

@zaxtax zaxtax requested a review from ricardoV94 October 4, 2025 23:03
@ricardoV94
Copy link
Member

If you rebase from main it shuold pick the newer PyTensor with the xtensor function you need

@zaxtax zaxtax force-pushed the adding_other_distributions branch from e8f0025 to 4c95389 Compare October 23, 2025 14:24
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.47%. Comparing base (3c42a18) to head (bb3e008).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pymc/dims/distributions/vector.py 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7921      +/-   ##
==========================================
+ Coverage   89.33%   91.47%   +2.14%     
==========================================
  Files         116      116              
  Lines       18904    18939      +35     
==========================================
+ Hits        16887    17325     +438     
+ Misses       2017     1614     -403     
Files with missing lines Coverage Δ
pymc/dims/distributions/transforms.py 100.00% <100.00%> (ø)
pymc/dims/distributions/vector.py 90.00% <92.85%> (+0.44%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zaxtax
Copy link
Contributor Author

zaxtax commented Oct 23, 2025

@ricardoV94 the failing test seems unrelated to my PR

@ricardoV94
Copy link
Member

ricardoV94 commented Oct 23, 2025

Yes it is not, it's a warning that's no longer emitted in the latest PyTensor. Can you remove it in a separate commit?

@zaxtax zaxtax force-pushed the adding_other_distributions branch from 77d39f7 to bb3e008 Compare October 23, 2025 20:29
@zaxtax zaxtax merged commit 2af4eb0 into pymc-devs:main Oct 23, 2025
26 checks passed
@zaxtax zaxtax deleted the adding_other_distributions branch October 23, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants