-
Notifications
You must be signed in to change notification settings - Fork 2.2k
DOC: fix mobile menu #7968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
immortal71
wants to merge
6
commits into
pymc-devs:main
Choose a base branch
from
immortal71:fix/mobile-menu-navigation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−1
Open
DOC: fix mobile menu #7968
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
552dff8
DOC: fix mobile menu
immortal71 94e45d7
Update docs/source/_static/js/mobile-menu-fix.js
immortal71 d19dd97
Update docs/source/_static/js/mobile-menu-fix.js
immortal71 99cd2e3
Update docs/source/_static/css/mobile-menu-fix.css
immortal71 19d07b4
Update docs/source/_static/css/mobile-menu-fix.css
immortal71 8e42bd3
Update docs/source/_static/css/mobile-menu-fix.css
immortal71 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* Mobile menu fix: ensure overlay is clickable on iOS */ | ||
|
|
||
| /* Raise the stacked navigation elements above possible overlays */ | ||
| .primary-toggle, | ||
| .secondary-toggle, | ||
| .mobile-menu-container .navbar, | ||
| .mobile-menu-container .navbar-collapse, | ||
| #pst-primary-sidebar-modal, | ||
| #pst-secondary-sidebar-modal { | ||
| z-index: 1500; | ||
| pointer-events: auto !important; | ||
| } | ||
|
|
||
| /* | ||
| * Ensure the modal overlay allows pointer events to reach menu links. | ||
| * Both `pointer-events: auto` and a high `z-index` are necessary because: | ||
| * - Some themes/modal implementations use overlays that block pointer events or stack above menu links, | ||
| * making them unclickable (especially on iOS). | ||
| * - This rule ensures that the backdrop does not block interaction with menu links, | ||
| * and that the stacking order is correct so links remain accessible. | ||
| * If the theme/modal implementation changes, review whether this workaround is still needed. | ||
| */ | ||
| .pst-modal-backdrop { | ||
| pointer-events: auto !important; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Mobile menu fix: make touch interactions on mobile (iOS/Safari) reliably trigger | ||
| // the mobile navigation toggle. Minimal, defensive enhancement. | ||
| document.addEventListener('DOMContentLoaded', function () { | ||
| try { | ||
| const selectors = [ | ||
| '.primary-toggle', | ||
| '.secondary-toggle', | ||
| '[data-toggle="collapse"]', | ||
| '.navbar [aria-controls][aria-expanded]' | ||
| ].join(','); | ||
| const controls = Array.from(document.querySelectorAll(selectors)); | ||
| controls.forEach(el => { | ||
| if (el.__pymc_touchbound) return; | ||
| el.__pymc_touchbound = true; | ||
| el.addEventListener('touchstart', function (e) { | ||
| // iOS sometimes doesn't synthesize click events for transformed | ||
| // elements or elements in certain stacking contexts. Best-effort | ||
| // bridge: prevent default then dispatch a MouseEvent click. | ||
| try { | ||
| // e.preventDefault(); // Removed to allow scrolling on touch devices | ||
| this.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true })); | ||
| } catch (err) { | ||
| // ignore errors | ||
| } | ||
| }, { passive: false }); | ||
| }); | ||
| } catch (err) { | ||
| // swallow errors to avoid breaking docs | ||
| } | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The synthetic MouseEvent dispatched here may bypass accessibility features that screen readers and assistive technologies rely on. Touch events are properly exposed to accessibility APIs, but synthetic click events might not be. Consider testing with VoiceOver (iOS) or TalkBack (Android) to ensure users with screen readers can still navigate the menu, or add explicit ARIA live region announcements when the menu state changes.