Derive Categorical from Argmin/Argmax#8072
Open
ricardoV94 wants to merge 4 commits intopymc-devs:mainfrom
Open
Derive Categorical from Argmin/Argmax#8072ricardoV94 wants to merge 4 commits intopymc-devs:mainfrom
ricardoV94 wants to merge 4 commits intopymc-devs:mainfrom
Conversation
ricardoV94
force-pushed
the
categorical_derived_rvs
branch
from
7cc3115 to
5ff3f21
Compare
ricardoV94
force-pushed
the
categorical_derived_rvs
branch
from
5ff3f21 to
edd4bc7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8072 +/- ##
==========================================
- Coverage 90.80% 90.80% -0.01%
==========================================
Files 121 121
Lines 19443 19555 +112
==========================================
+ Hits 17656 17756 +100
- Misses 1787 1799 +12
🚀 New features to boost your workflow:
|
Member
Author
|
CC @eclipse1605 if you want to review / ask questions |
eclipse1605
reviewed
Jan 28, 2026
| import numpy as np | ||
| import pytensor.tensor as pt | ||
|
|
||
| from numpy.lib._array_utils_impl import normalize_axis_tuple |
Contributor
There was a problem hiding this comment.
why are we importing it from a priv numpy module instead of using numpy.lib.array_utils.normalize_axis_tuple?
Member
Author
There was a problem hiding this comment.
My editor chose that import automatically, you're right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couldn't resist the temptation...
Needed some import shuffling so that I'm allowed to import a SymbolicRandomVariable in logprob rewrites