Skip to content

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Oct 3, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@maresb
Copy link
Contributor Author

maresb commented Oct 3, 2024

Ya, this is still failing Wrong PR, this is working! 🎉

@maresb maresb mentioned this pull request Oct 3, 2024
11 tasks
@maresb
Copy link
Contributor Author

maresb commented Oct 3, 2024

@ricardoV94, it looks to me like this fixes the issue with the wheels.

I also added build-and-inspect-python-package which give a bunch of really useful diagnostics on the PyPI action summary page:
image

I need to switch off to some other work. Would you be able to take care of deleting the bad tags/releases and rereleasing?

@maresb
Copy link
Contributor Author

maresb commented Oct 3, 2024

(Note that the workflow I added creates the superfluous "Packages" artifact.)

In order to check if the wheels are broken I download the wheels-ubuntu-20.04 artifact (from the summary page linked in my previous comment), and then I look at the filenames and make sure that a version has been detected correctly:
image

@maresb maresb marked this pull request as ready for review October 3, 2024 11:56
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (222cd4a) to head (1b3b895).
Report is 113 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1013   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         183      183           
  Lines       47740    47740           
  Branches    11616    11616           
=======================================
  Hits        39027    39027           
+ Misses       6520     6518    -2     
- Partials     2193     2195    +2     

see 2 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit 117f80d into pymc-devs:main Oct 3, 2024
61 checks passed
@maresb maresb deleted the upgrade-cibuildwheel branch October 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants