Skip to content

Robust logsumexp #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Robust logsumexp #1227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67e2452
Robustified logsumexp
fonnesbeck Feb 20, 2025
150f908
Ruff error
fonnesbeck Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pytensor/tensor/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2753,8 +2753,10 @@ def logsumexp(x, axis=None, keepdims=False):
tensor

"""

return log(sum(exp(x), axis=axis, keepdims=keepdims))
result = log(
sum(exp(x - max(x, axis=axis, keepdims=True)), axis=axis, keepdims=keepdims)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also a bit more complicated than that to handle cases of all infinities. The graph is pretty messy, that's why we do it later only

)
return result + max(x, axis=axis, keepdims=keepdims)


# Predefine all batched variations of Dot
Expand Down