Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 24, 2025

Allows getting rid o MergeOptimizer, constand_foling that are not very informative.


📚 Documentation preview 📚: https://pytensor--1240.org.readthedocs.build/en/1240/

@ricardoV94 ricardoV94 added enhancement New feature or request graph rewriting labels Feb 24, 2025
@ricardoV94 ricardoV94 force-pushed the optimizer_verbose_ignore branch from d890fd0 to 7d672b0 Compare February 24, 2025 10:58
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.98%. Comparing base (f37380f) to head (0a2c2d3).
Report is 156 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/graph/rewriting/basic.py 40.00% 1 Missing and 2 partials ⚠️
pytensor/graph/features.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   81.99%   81.98%   -0.02%     
==========================================
  Files         188      188              
  Lines       48567    48581      +14     
  Branches     8677     8683       +6     
==========================================
+ Hits        39823    39827       +4     
- Misses       6581     6586       +5     
- Partials     2163     2168       +5     
Files with missing lines Coverage Δ
pytensor/configdefaults.py 73.54% <100.00%> (+0.08%) ⬆️
pytensor/configparser.py 92.55% <100.00%> (+0.02%) ⬆️
pytensor/graph/fg.py 90.80% <100.00%> (+0.10%) ⬆️
pytensor/graph/features.py 65.07% <60.00%> (-0.16%) ⬇️
pytensor/graph/rewriting/basic.py 69.50% <40.00%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 force-pushed the optimizer_verbose_ignore branch 2 times, most recently from 52f3acd to 9bf8e85 Compare February 24, 2025 11:46
@ricardoV94 ricardoV94 requested a review from Armavica February 24, 2025 15:00

config.add(
"optimizer_verbose_ignore",
"Ignore rewrites from optimizers with these names. Separate names with ','",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the following, to be clear that this is about ignoring the display and not the rewrites themselves.

Suggested change
"Ignore rewrites from optimizers with these names. Separate names with ','",
"Don't print rewrites from optimizers with these names. Separate names with ','",

@ricardoV94 ricardoV94 force-pushed the optimizer_verbose_ignore branch from 9bf8e85 to 0a2c2d3 Compare February 24, 2025 17:11
@ricardoV94 ricardoV94 requested a review from Armavica February 24, 2025 17:11
@ricardoV94 ricardoV94 merged commit 7f03125 into pymc-devs:main Feb 25, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request graph rewriting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants