Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Feb 24, 2025

This shows up in some imputation models in PyMC. Numba supports this case, so no reason to block it.


📚 Documentation preview 📚: https://pytensor--1243.org.readthedocs.build/en/1243/

@ricardoV94 ricardoV94 changed the title Don't use objectmode with vector boolean inc_subtensor Don't use numba objectmode with vector boolean inc_subtensor Feb 24, 2025
@ricardoV94 ricardoV94 force-pushed the numba_inc_subtensor_bool branch from 81130a0 to 04b0b57 Compare February 24, 2025 16:43
@ricardoV94 ricardoV94 merged commit 53763f5 into pymc-devs:main Feb 24, 2025
71 checks passed
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.98%. Comparing base (f37380f) to head (04b0b57).
Report is 156 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   81.99%   81.98%   -0.02%     
==========================================
  Files         188      188              
  Lines       48567    48567              
  Branches     8677     8677              
==========================================
- Hits        39823    39818       -5     
- Misses       6581     6584       +3     
- Partials     2163     2165       +2     
Files with missing lines Coverage Δ
pytensor/link/numba/dispatch/subtensor.py 95.34% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 deleted the numba_inc_subtensor_bool branch April 21, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants