Skip to content

Conversation

Aarsh-Wankar
Copy link
Contributor

@Aarsh-Wankar Aarsh-Wankar commented Mar 9, 2025

Description

The function enable_slice_literals in numba.dispatch.basic has a TODO here referencing a numba PR which has already been merged. This PR removes this function.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1280.org.readthedocs.build/en/1280/

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (89d5366) to head (00abe0d).
Report is 142 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   81.99%   81.99%   -0.01%     
==========================================
  Files         188      188              
  Lines       48608    48560      -48     
  Branches     8688     8682       -6     
==========================================
- Hits        39857    39815      -42     
+ Misses       6586     6583       -3     
+ Partials     2165     2162       -3     
Files with missing lines Coverage Δ
pytensor/link/numba/dispatch/basic.py 77.84% <ø> (-1.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Aarsh-Wankar
Copy link
Contributor Author

@jessegrabowski All the tests are passing. Are any more changes required?

@ricardoV94 ricardoV94 changed the title Remove enable_slice_literals function Remove enable_slice_literals function Mar 9, 2025
@ricardoV94 ricardoV94 merged commit 110e128 into pymc-devs:main Mar 9, 2025
74 checks passed
@ricardoV94
Copy link
Member

Thanks @Aarsh-Wankar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove enable_slice_literals from numba.dispatch.basic

2 participants