-
Notifications
You must be signed in to change notification settings - Fork 145
Provide static output shape for constant arange
#1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d314dfe
Modify arange to directly determine the shape from the arguments if p…
Abhinav-Khot bb56010
Fix overflow issue
Abhinav-Khot 65078a5
removed redundant variable
Abhinav-Khot 098541f
Fix minor issue
Abhinav-Khot ebb0e75
Modify make_node for completeness and clarity
Abhinav-Khot 11a915b
minor fix for readability
Abhinav-Khot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3224,13 +3224,29 @@ def __init__(self, dtype): | |
self.dtype = dtype | ||
|
||
def make_node(self, start, stop, step): | ||
types = TensorConstant | ||
shape = (None,) | ||
|
||
# if it is possible to directly determine the shape i.e static shape is present, we find it. | ||
if ( | ||
isinstance(start, types) | ||
and isinstance(stop, types) | ||
and isinstance(step, types) | ||
): | ||
length = max( | ||
ricardoV94 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
np.max(np.ceil((stop.value - start.value) / step.value)) | ||
ricardoV94 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
.astype(int) | ||
.item(), | ||
0, | ||
) | ||
shape = (length,) | ||
|
||
start, stop, step = map(as_tensor_variable, (start, stop, step)) | ||
assert start.ndim == 0 | ||
assert stop.ndim == 0 | ||
assert step.ndim == 0 | ||
|
||
inputs = [start, stop, step] | ||
outputs = [tensor(dtype=self.dtype, shape=(None,))] | ||
outputs = [tensor(dtype=self.dtype, shape=shape)] | ||
|
||
return Apply(self, inputs, outputs) | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.