-
Notifications
You must be signed in to change notification settings - Fork 145
Don't run the PyPi job all the time #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 231 231
Lines 52364 52364
Branches 9217 9217
=======================================
Hits 42962 42962
Misses 7094 7094
Partials 2308 2308 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like there's potential to group the whole condition of the if
job runs into an output of the check_changes
job. I'm not sure how to do that though. Maybe Claude knows. I've added a suggestion on to kind of hint at what I mean.
Would either of you @lucianopaz or @maresb be willing to take the PR over the finish line? |
I'm overwhelmed at the moment. You can try pinging me again in a few weeks |
I can take over next week |
Super |
Looks like the |
b4b1f4c
to
fe6b484
Compare
It's fixed now @maresb, @ricardoV94. Let me know if you think it's ok. |
@lucianopaz you can rebase for the tests to pass |
@maresb do you want to take another look? |
Co-authored-by: Ben Mares <[email protected]>
This should have been squashed merged |
This was mostly Claude-generated changes, so appreciate careful review.
Trying to save tons of compute time we wast building the cython-scan extension on the ubuntu wheel for every PR and push to main. Closes #219
📚 Documentation preview 📚: https://pytensor--1363.org.readthedocs.build/en/1363/