Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Apr 9, 2025

This was mostly Claude-generated changes, so appreciate careful review.

Trying to save tons of compute time we wast building the cython-scan extension on the ubuntu wheel for every PR and push to main. Closes #219


📚 Documentation preview 📚: https://pytensor--1363.org.readthedocs.build/en/1363/

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.04%. Comparing base (ae38884) to head (cf0ec00).
⚠️ Report is 110 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1363   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files         231      231           
  Lines       52364    52364           
  Branches     9217     9217           
=======================================
  Hits        42962    42962           
  Misses       7094     7094           
  Partials     2308     2308           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 requested review from lucianopaz and maresb April 9, 2025 18:08
Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like there's potential to group the whole condition of the if job runs into an output of the check_changes job. I'm not sure how to do that though. Maybe Claude knows. I've added a suggestion on to kind of hint at what I mean.

@ricardoV94 ricardoV94 added the help wanted Extra attention is needed label May 30, 2025
@ricardoV94
Copy link
Member Author

ricardoV94 commented May 30, 2025

Would either of you @lucianopaz or @maresb be willing to take the PR over the finish line?

@maresb
Copy link
Contributor

maresb commented May 30, 2025

Would either of you @lucianopaz or @maresb be willing to take the PR over the finish line?

I'm overwhelmed at the moment. You can try pinging me again in a few weeks

@lucianopaz
Copy link
Member

I can take over next week

@ricardoV94
Copy link
Member Author

I can take over next week

Super

@lucianopaz lucianopaz self-assigned this Jun 8, 2025
@lucianopaz lucianopaz marked this pull request as ready for review June 8, 2025 21:08
@lucianopaz
Copy link
Member

Looks like the check_changes job isn't setting the correct output and some jobs are skipped.

@lucianopaz lucianopaz force-pushed the pypi-job branch 2 times, most recently from b4b1f4c to fe6b484 Compare June 9, 2025 10:32
@lucianopaz
Copy link
Member

It's fixed now @maresb, @ricardoV94. Let me know if you think it's ok.

@ricardoV94
Copy link
Member Author

@lucianopaz you can rebase for the tests to pass

@ricardoV94
Copy link
Member Author

@maresb do you want to take another look?

@lucianopaz lucianopaz merged commit 7584614 into pymc-devs:main Jul 4, 2025
75 checks passed
@ricardoV94
Copy link
Member Author

This should have been squashed merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed no releasenotes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build wheels on Ubuntu CI takes a long time

3 participants