Skip to content

Use PyObject_CallNoArgs to call thunks from VM #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Use PyObject_CallNoArgs to call thunks from VM #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pytensor/link/c/c_code/lazylinker_c.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ static PyObject *pycall(CLazyLinker *self, Py_ssize_t node_idx, int verbose) {
double t0 = pytime(NULL);
if (verbose)
fprintf(stderr, "calling via Python (node %i)\n", (int)node_idx);
rval = PyObject_CallObject(thunk, NULL);
rval = PyObject_CallNoArgs(thunk);
if (rval) {
double t1 = pytime(NULL);
double ti = PyFloat_AsDouble(PyList_GetItem(self->call_times, node_idx));
Expand All @@ -491,7 +491,7 @@ static PyObject *pycall(CLazyLinker *self, Py_ssize_t node_idx, int verbose) {
if (verbose) {
fprintf(stderr, "calling via Python (node %i)\n", (int)node_idx);
}
rval = PyObject_CallObject(thunk, NULL);
rval = PyObject_CallNoArgs(thunk);
}
return rval;
}
Expand Down Expand Up @@ -981,7 +981,7 @@ static PyTypeObject lazylinker_ext_CLazyLinkerType = {
};

static PyObject *get_version(PyObject *dummy, PyObject *args) {
PyObject *result = PyFloat_FromDouble(0.3);
PyObject *result = PyFloat_FromDouble(0.31);
return result;
}

Expand Down
2 changes: 1 addition & 1 deletion pytensor/link/c/lazylinker_c.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
_logger = logging.getLogger(__file__)

force_compile = False
version = 0.3 # must match constant returned in function get_version()
version = 0.31 # must match constant returned in function get_version()
lazylinker_ext: ModuleType | None = None


Expand Down