Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 13, 2025

Allow controlling the rewrite database and the dprint settings. Also allow attaching an existing FG which already has the history feature.

Marking as no releasenotes, because we didn't yet release PyTensor with the widget


📚 Documentation preview 📚: https://pytensor--1469.org.readthedocs.build/en/1469/

Copy link
Contributor

@zaxtax zaxtax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I feel like the AlreadyThere exception needs a better name, but that's not a blocker for this.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.02%. Comparing base (5f5be92) to head (4d67671).
⚠️ Report is 129 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/ipython.py 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage   82.03%   82.02%   -0.01%     
==========================================
  Files         214      214              
  Lines       50398    50403       +5     
  Branches     8897     8897              
==========================================
  Hits        41345    41345              
- Misses       6848     6853       +5     
  Partials     2205     2205              
Files with missing lines Coverage Δ
pytensor/ipython.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94
Copy link
Member Author

LGTM!

I feel like the AlreadyThere exception needs a better name, but that's not a blocker for this.

Suggestions? Feel free to open an issue, don't love it either

@ricardoV94 ricardoV94 merged commit cca20eb into pymc-devs:main Jun 13, 2025
73 of 74 checks passed
@zaxtax
Copy link
Contributor

zaxtax commented Jun 13, 2025 via email

@ricardoV94
Copy link
Member Author

What about AlreadyAttachedError ?

On Fri, 13 Jun 2025, 19:24 Ricardo Vieira, @.***> wrote:

Merged #1469 #1469 into main.


Reply to this email directly, view it on GitHub
#1469 (comment), or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACCUPZVBDANZHEOSDBLPL3DMCNXAVCNFSM6AAAAAB7HL5Q3SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJYGEZTQMBSGY2DIOA
.
You are receiving this because your review was requested.Message ID:
@.***>

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants