Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 26, 2025

The implementation wrongly considered x.transpose(...) as a reverse transpose, but it's just a no-op in that cas.

Also renamed the user-facing kwarg to dim to be aligned with xarray.

CC @AllenDowney


📚 Documentation preview 📚: https://pytensor--1500.org.readthedocs.build/en/1500/

@ricardoV94 ricardoV94 changed the title Fix xtensor Transpose with ellipsis Fix xtensor (...,) Transpose Jun 26, 2025
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.99%. Comparing base (236e50d) to head (8f1df3b).
⚠️ Report is 119 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1500   +/-   ##
=======================================
  Coverage   81.98%   81.99%           
=======================================
  Files         231      231           
  Lines       52192    52253   +61     
  Branches     9185     9203   +18     
=======================================
+ Hits        42790    42843   +53     
- Misses       7094     7099    +5     
- Partials     2308     2311    +3     
Files with missing lines Coverage Δ
pytensor/xtensor/shape.py 77.85% <100.00%> (+0.33%) ⬆️
pytensor/xtensor/type.py 68.28% <100.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 0bb15f9 into pymc-devs:main Jun 26, 2025
74 checks passed
@ricardoV94 ricardoV94 added bug Something isn't working xtensor labels Jun 26, 2025
@ricardoV94 ricardoV94 deleted the fix_transpose branch June 26, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working xtensor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant