Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 4, 2025

It makes it easier for users to let us know what kind of graph isn't actually compiling this way.


📚 Documentation preview 📚: https://pytensor--1520.org.readthedocs.build/en/1520/

@ricardoV94 ricardoV94 changed the title Add compiler_verbose config flag Add compiler_verbose config flag Jul 4, 2025
@ricardoV94 ricardoV94 requested a review from jessegrabowski July 4, 2025 08:56
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.71%. Comparing base (ae38884) to head (480cab1).
⚠️ Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/link/numba/dispatch/basic.py 0.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
- Coverage   82.04%   81.71%   -0.33%     
==========================================
  Files         231      230       -1     
  Lines       52364    52935     +571     
  Branches     9217     9404     +187     
==========================================
+ Hits        42962    43257     +295     
- Misses       7094     7246     +152     
- Partials     2308     2432     +124     
Files with missing lines Coverage Δ
pytensor/configdefaults.py 73.63% <100.00%> (+0.08%) ⬆️
pytensor/configparser.py 92.58% <100.00%> (+0.02%) ⬆️
pytensor/link/numba/dispatch/basic.py 77.86% <0.00%> (-1.23%) ⬇️

... and 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but need to add a section to docs/library/config.rst

@ricardoV94
Copy link
Member Author

No I shouldn't, that should be generated automatically. It's bad design if it's not and I would open an issue for that

@ricardoV94
Copy link
Member Author

It's the year 2025 ffs

@jessegrabowski
Copy link
Member

In that case could you beef up the help string of the flag a bit, so that in the future when this section is auto-generated, it's helpful. It appears to only do anything in numba mode, and it dprints nodes? I somewhat don't get it.

@ricardoV94
Copy link
Member Author

Right now it only does that but could be used for whenever we want to output information during compilation (as opposed to during rewrite). The node dprint is because when someone says numba is falling back to objectmode for stuff like AdvancedSubtensor that's not enough info, because there are 99 flavors of it

Copy link
Member

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine then, I'm approving, but I will point out that you could have written something shorter than your reply to satisfy my request, rather than the reply itself.

@ricardoV94
Copy link
Member Author

I'm AFK

@jessegrabowski jessegrabowski merged commit 75e8f99 into pymc-devs:main Sep 5, 2025
62 checks passed
@ricardoV94
Copy link
Member Author

Thanks for finishing it up

@ricardoV94 ricardoV94 deleted the compiler_verbose branch September 6, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants