Skip to content

Use stricter numerical tolerance in rewrites and allow casting in PatternNodeRewriter #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2025
+125 −32
Merged

Use stricter numerical tolerance in rewrites and allow casting in PatternNodeRewriter #1526

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c54a34a
Implemented allow_cast in PatternNodeRewriter
Jul 4, 2025
6277546
Added test cases for which issue #1497 fails
Jul 7, 2025
227a468
Changed PatternNodeRewriter::transform to allow types that do not con…
Jul 7, 2025
5e7fd29
Address #1497 by changing instances of np.isclose to a function isclo…
Jul 7, 2025
700b0d8
Addressed failed tests (with older python/numpy versions)
Jul 8, 2025
58de233
Addressed feedback by ricardoV94
Jul 8, 2025
17fbc90
Test PatternNodeRewriter doesn't support multi-output nodes in pattern
ricardoV94 Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pytensor/graph/rewriting/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,9 +1668,11 @@ def transform(self, fgraph, node, get_nodes=True):
):
return False
else:
out_dtype = node.outputs[0].type.dtype
if self.allow_cast and ret.owner.outputs[0].type.dtype != out_dtype:
ret = pytensor.tensor.basic.cast(ret, out_dtype)
if self.allow_cast:
out_dtype = getattr(node.outputs[0].type, "dtype", None)
ret_dtype = getattr(ret.owner.outputs[0].type, "dtype", None)
if ret_dtype != out_dtype:
ret = pytensor.tensor.basic.cast(ret, out_dtype)
if not node.outputs[0].type.is_super(ret.owner.outputs[0].type):
return False
else:
Expand Down