Skip to content

Conversation

jessegrabowski
Copy link
Member

@jessegrabowski jessegrabowski commented Jul 8, 2025

Description

Small enhancement to block_diag. Adds some reasoning about static shape information to make_node, and propagates this information if all input shapes are known.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1529.org.readthedocs.build/en/1529/

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.85%. Comparing base (1d82fb4) to head (a3e9f89).
⚠️ Report is 104 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   82.04%   81.85%   -0.19%     
==========================================
  Files         230      230              
  Lines       52346    52522     +176     
  Branches     9212     9345     +133     
==========================================
+ Hits        42947    42992      +45     
  Misses       7095     7095              
- Partials     2304     2435     +131     
Files with missing lines Coverage Δ
pytensor/tensor/slinalg.py 93.39% <100.00%> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94
Copy link
Member

Why is there a distinct BaseBlockDiag, what does it do?

@jessegrabowski
Copy link
Member Author

It holds logic shared by BlockDiag and SparseBlockDiag

@ricardoV94
Copy link
Member

Thanks didn't know we have a sparse

@jessegrabowski jessegrabowski merged commit b9fc4f8 into pymc-devs:main Jul 9, 2025
73 checks passed
@jessegrabowski jessegrabowski deleted the block-diag-shape branch July 9, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants