Fix AdvancedIncSubtensor1 C-compilation with empty indices #1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Jul 25, 2025
| idx_may_be_neg = not ( | ||
| # Empty idx needs no negative checks | ||
| idx_.type.shape[0] == 0 | ||
| or (isinstance(idx_, Constant) and idx_.data.min() >= 0) |
There was a problem hiding this comment.
we always have static shape for constants, so the check above precludes taking the min of an empty array, which was the original bug
jessegrabowski
approved these changes
Jul 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage 81.49% 81.49%
=======================================
Files 232 232
Lines 53122 53122
Branches 9444 9444
=======================================
+ Hits 43292 43293 +1
Misses 7382 7382
+ Partials 2448 2447 -1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't take the min of an empty index. This Op is useless, but depending on how the graph is build / optimizations done, there are no guarantees it will be removed.
📚 Documentation preview 📚: https://pytensor--1551.org.readthedocs.build/en/1551/