-
Notifications
You must be signed in to change notification settings - Fork 139
Add rewrite for log(sqrt(x)) #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a small note
Co-authored-by: Ricardo Vieira <[email protected]>
Co-authored-by: Ricardo Vieira <[email protected]>
Neat! |
There's a new test utility that does equal_computation, and also dprints the graph if it fails, that we can start using for tests. It makes it easier to debug why the test is failing |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (84.61%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
==========================================
- Coverage 81.53% 81.53% -0.01%
==========================================
Files 230 230
Lines 53066 53079 +13
Branches 9423 9425 +2
==========================================
+ Hits 43269 43279 +10
- Misses 7364 7365 +1
- Partials 2433 2435 +2
🚀 New features to boost your workflow:
|
Thanks hero |
PS: a bit less noisy if you create branches on your fork than on the pytensor one, so we don't need to go about deleting stale branches in the future |
Description
Related Issue
log(sqrt(x)) -> 0.5 * log(x)
#1437Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1555.org.readthedocs.build/en/1555/