-
Notifications
You must be signed in to change notification settings - Fork 139
Handles axis=None
symbolically instead of within CumOp
#1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-4ded62d7-b0ca-436b-9c1f-545c389765f5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using flatten Co-authored-by: ricardoV94 <[email protected]>
Copilot finished work on behalf of
ricardoV94
August 9, 2025 03:50
ricardoV94
requested changes
Aug 9, 2025
@copilot address review comments |
…ive axis handling Co-authored-by: ricardoV94 <[email protected]>
Copilot finished work on behalf of
ricardoV94
August 9, 2025 04:11
ricardoV94
reviewed
Aug 9, 2025
… eliminate code duplication Co-authored-by: ricardoV94 <[email protected]>
Copilot finished work on behalf of
ricardoV94
August 9, 2025 04:33
axis=None
symbolically instead of within CumOp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1549
Summary
This PR refactors the cumulative sum/product operations to handle the special ravelling behavior of
axis=None
symbolically, making the code cleaner and more maintainable.Problem
Previously, when
cumsum(x, axis=None)
orcumprod(x, axis=None)
was called on a matrix, theCumOp
class internally handled the flattening with special logic scattered throughout:make_node()
,grad()
,infer_shape()
, andc_code()
Solution
The refactoring separates concerns by handling the ravelling symbolically:
Before:
After:
Key Changes
Modified
cumsum
/cumprod
functions: Whenaxis=None
, explicitly flatten the input first, then apply cumsum/cumprod withaxis=0
Simplified
CumOp
class:axis=None
)make_node
,grad
,infer_shape
,c_code
Updated backend dispatchers: Removed axis=None handling from PyTorch, JAX, and Numba backends since
CumOp
now always receives integer axesUpdated tests: Modified test cases to use the new simplified API while maintaining coverage of axis=None behavior through the public functions
Benefits
CumOp
only handles specific integer axesflatten → cumsum
chainBackward Compatibility
✅ All existing user code continues to work unchanged
✅ Same computational results for all operations
✅ Same gradient behavior
✅ Same output shapes and types
The refactoring only changes the internal implementation - the public API remains identical.
Example
This makes the code more maintainable while preserving all existing functionality.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.