Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 9, 2025

This PR adds a comprehensive .github/copilot-instructions.md file to onboard GitHub Copilot coding agents to the PyTensor repository. The goal is to significantly improve agent efficiency by reducing exploration time and build/test failures.

What's Included

The instructions file provides essential information that agents need to work effectively:

Critical Environment Setup

  • Micromamba requirement: All commands must use micromamba run -n pytensor-test <command> since PyTensor is pre-installed via .github/workflows/copilot-setup-steps.yml
  • Clear examples of correct command usage

Build & Test Instructions

  • Complete test commands with execution times
  • Documentation building steps
  • MyPy type checking guidance
  • Important note that pre-commit/ruff are NOT available in the copilot environment

PyTensor-Specific Design Principles

  • API differences from NumPy: Lazy evaluation, pure semantics, immutable/hashable variables, static shape requirements
  • Config flags: Tests run with config.floatX == "float32" and config.mode = "FAST_COMPILE", requiring special handling
  • Code style: Sparse comments, succinct tests, prefer graph testing over numerical evaluation

Repository Structure

  • Concise overview of root files, source modules, and test structure
  • Key file locations (configdefaults.py, gradient.py, compile/, graph/, link/, tensor/, etc.)

CI/CD Pipeline

  • Test matrix details (Python versions, config combinations, 7-part test split)
  • PR requirements and validation steps

Common Issues

  • Solutions for import errors, Cython rebuilds, BLAS verification, and config test failures

Benefits

This file will help Copilot agents:

  1. ✅ Run commands correctly on the first try (no environment confusion)
  2. ✅ Write PyTensor-compatible code (respecting lazy evaluation, pure semantics)
  3. ✅ Create appropriate tests (using assert_equal_computations, minimizing compilation)
  4. ✅ Handle config-dependent tests (floatX, FAST_COMPILE mode)
  5. ✅ Navigate the codebase efficiently (knowing where to find/add code)

File Size

The instructions are 119 lines (~2 pages), meeting the size requirement while remaining comprehensive.

All commands in the instructions have been tested and validated to work correctly.

Original prompt

Your task is to "onboard" this repository to Copilot coding agent by adding a .github/copilot-instructions.md file in the repository that contains information describing how a coding agent seeing it for the first time can work most efficiently.

You will do this task only one time per repository and doing a good job can SIGNIFICANTLY improve the quality of the agent's work, so take your time, think carefully, and search thoroughly before writing the instructions.

- Reduce the likelihood of a coding agent pull request getting rejected by the user due to generating code that fails the continuous integration build, fails a validation pipeline, or having misbehavior. - Minimize bash command and build failures. - Allow the agent to complete its task more quickly by minimizing the need for exploration using grep, find, str_replace_editor, and code search tools. - Instructions must be no longer than 2 pages. - Instructions must not be task specific.

Add the following high level details about the codebase to reduce the amount of searching the agent has to do to understand the codebase each time:

  • A summary of what the repository does.
  • High level repository information, such as the size of the repo, the type of the project, the languages, frameworks, or target runtimes in use.

Add information about how to build and validate changes so the agent does not need to search and find it each time.

  • For each of bootstrap, build, test, run, lint, and any other scripted step, document the sequence of steps to take to run it successfully as well as the versions of any runtime or build tools used.
  • Each command should be validated by running it to ensure that it works correctly as well as any preconditions and postconditions.
  • Try cleaning the repo and environment and running commands in different orders and document errors and and misbehavior observed as well as any steps used to mitigate the problem.
  • Run the tests and document the order of steps required to run the tests.
  • Make a change to the codebase. Document any unexpected build issues as well as the workarounds.
  • Document environment setup steps that seem optional but that you have validated are actually required.
  • Document the time required for commands that failed due to timing out.
  • When you find a sequence of commands that work for a particular purpose, document them in detail.
  • Use language to indicate when something should always be done. For example: "always run npm install before building".
  • Record any validation steps from documentation.

List key facts about the layout and architecture of the codebase to help the agent find where to make changes with minimal searching.

  • A description of the major architectural elements of the project, including the relative paths to the main project files, the location
    of configuration files for linting, compilation, testing, and preferences.
  • A description of the checks run prior to check in, including any GitHub workflows, continuous integration builds, or other validation pipelines.
  • Document the steps so that the agent can replicate these itself.
  • Any explicit validation steps that the agent can consider to have further confidence in its changes.
  • Dependencies that aren't obvious from the layout or file structure.
  • Finally, fill in any remaining space with detailed lists of the following, in order of priority: the list of files in the repo root, the
    contents of the README, the contents of any key source files, the list of files in the next level down of directories, giving priority to the more structurally important and snippets of code from key source files, such as the one containing the main method.
- Perform a comprehensive inventory of the codebase. Search for and view: - README.md, CONTRIBUTING.md, and all other documentation files. - Search the codebase for build steps and indications of workarounds like 'HACK', 'TODO', etc. - All scripts, particularly those pertaining to build and repo or environment setup. - All build and actions pipelines. - All project files. - All configuration and linting files. - For each file: - think: are the contents or the existence of the file information that the coding agent will need to implement, build, test, validate, or demo a code change? - If yes: - Document the command or information in detail. - Explicitly indicate which commands work and which do not and the order in which commands should be run. - Document any errors encountered as well as the steps taken to workaround them. - Document any other steps or information that the agent can use to reduce time spent exploring or trying and failing to run bash commands. - Finally, explicitly instruct the agent to trust the instructions and only perform a search if the information in the instruction...

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Add Copilot onboarding instructions to repository Add Copilot instructions file for repository onboarding Oct 9, 2025
@Copilot Copilot AI requested a review from ricardoV94 October 9, 2025 09:08
Copilot finished work on behalf of ricardoV94 October 9, 2025 09:08
Updated PyTensor instructions to clarify environment usage, testing commands, and design principles.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive .github/copilot-instructions.md file to enhance GitHub Copilot coding agents' efficiency when working with the PyTensor repository. The instructions provide essential information about environment setup, build processes, design principles, and repository structure to minimize exploration time and prevent common failures.

  • Establishes mandatory micromamba environment usage for all commands
  • Documents PyTensor-specific design principles and API differences from NumPy
  • Provides complete testing, building, and validation workflows with execution guidance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ricardoV94 ricardoV94 marked this pull request as ready for review October 9, 2025 09:49
@ricardoV94 ricardoV94 requested a review from Armavica October 9, 2025 12:45
@Armavica
Copy link
Member

Armavica commented Oct 9, 2025

@ricardoV94 Sorry, I don't use Copilot and would prefer not interact with it or with LLMs in general

@Armavica Armavica removed their request for review October 9, 2025 13:00
@ricardoV94
Copy link
Member

@ricardoV94 Sorry, I don't use Copilot and would prefer not interact with it or with LLMs in general

I think the onboard is useful for regular folks as well, that's why I tagged other people for review.

@ricardoV94
Copy link
Member

ricardoV94 commented Oct 9, 2025

Also, as someone who reviews 99% of the PRs in this repo, and has to deal with an increasing amount of AI slop, I would rather reduce my work upfront.

All the recommendations on testing and design principles that I manually included, are things I see myself mentioning over and over again. Even if one chooses not to use copilot/LLMs themselves, they will have to see work done by those tools sooner or later, and if we can make that better everybody wins.

- `gradient.py`: Auto-differentiation
- `compile/`: Function compilation
- `graph/`: IR and optimization (`graph/rewriting/`)
- `link/`: Backends (`c/`, `jax/`, `numba/`, `pytorch/`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mlx?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bleeding edge


Tests are run with `config.floatX == "float32"` and `config.mode = "FAST_COMPILE"`. If needed:
- Cast numerical values `test_value.astype(symbolic_var.type.dtype)`
- Use custom function mode `get_default_mode().excluding("fusion")` or skip tests in `FAST_COMPILE`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "skip tests in FAST_COMPILE" mean

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a test is only relevant in fast run, skip in fast compile. I'll remove that or reword

## Trust These Instructions
These instructions are comprehensive and tested. Only search for additional information if:
1. Instructions are incomplete for your specific task
2. Instructions are found to be incorrect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it effective to give it an "out" like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the prompt they suggested on the GitHub docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants