Skip to content

Handle slices in mlx_funcify_IncSubtensor #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+265 −11
Open

Handle slices in mlx_funcify_IncSubtensor #1692

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bff3685
Handle slices in `mlx_funcify_IncSubtensor`
jessegrabowski Oct 24, 2025
a63e759
Create test_mlx_indexing_behavior.py
cetagostini Oct 28, 2025
119e7e6
Fix MLX indexing to support np.int64 and NumPy scalars
cetagostini Oct 28, 2025
116a1bd
Add missing newline at end of files
cetagostini Oct 28, 2025
4f7ae9f
modify
cetagostini Oct 28, 2025
9632ad6
Simplify based on Ricardo input
cetagostini Oct 28, 2025
c457a13
Update subtensor.py
cetagostini Oct 28, 2025
cd7a2d0
Simplify error msg
cetagostini Oct 28, 2025
449c2df
Refactor MLX subtensor dispatch and update test
cetagostini Oct 30, 2025
13be736
pushing a few more tests.
cetagostini Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pytensor/link/mlx/dispatch/subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,25 @@ def mlx_fn(x, indices, y):
return x

def incsubtensor(x, y, *ilist, mlx_fn=mlx_fn, idx_list=idx_list):
indices = indices_from_subtensor(ilist, idx_list)
def get_slice_int(element):
if element is None:
return None
try:
return int(element)
except Exception:
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a bare except Exception is too broad. This should catch specific exceptions like TypeError or ValueError that would occur when trying to convert a non-integer value. The current implementation could mask unexpected errors.

Suggested change
except Exception:
except (TypeError, ValueError):

Copilot uses AI. Check for mistakes.
return element

indices = tuple(
[
slice(
get_slice_int(s.start), get_slice_int(s.stop), get_slice_int(s.step)
)
if isinstance(s, slice)
else s
for s in indices_from_subtensor(ilist, idx_list)
]
)

if len(indices) == 1:
indices = indices[0]

Expand Down
13 changes: 13 additions & 0 deletions tests/link/mlx/test_subtensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,19 @@ def test_mlx_IncSubtensor_increment():
assert not out_pt.owner.op.set_instead_of_inc
compare_mlx_and_py([], [out_pt], [])

# Increment slice
out_pt = pt_subtensor.inc_subtensor(x_pt[:, :, 2:], st_pt)
compare_mlx_and_py([], [out_pt], [])

out_pt = pt_subtensor.inc_subtensor(x_pt[:, :, -3:], st_pt)
compare_mlx_and_py([], [out_pt], [])

out_pt = pt_subtensor.inc_subtensor(x_pt[::2, ::2, ::2], st_pt)
compare_mlx_and_py([], [out_pt], [])

out_pt = pt_subtensor.inc_subtensor(x_pt[:, :, :], st_pt)
compare_mlx_and_py([], [out_pt], [])


def test_mlx_AdvancedIncSubtensor_set():
"""Test advanced set operations using AdvancedIncSubtensor."""
Expand Down
Loading