Skip to content

Fix to minor bug in simulated data generation function #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

Fix to minor bug in simulated data generation function #505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e290244
fix issue with N not being used
drbenvincent Jul 19, 2025
67d550d
Add explanation about np.ones
drbenvincent Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions causalpy/data/simulate_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ def generate_time_series_data(
The intercept

"""
x = np.arange(0, 100, 1)
x = np.arange(0, N, 1)
df = pd.DataFrame(
{
"temperature": np.sin(x * 0.5) + 1,
"linear": np.linspace(0, 1, 100),
"causal effect": 10 * gamma(10).pdf(np.arange(0, 100, 1) - treatment_time),
"linear": np.linspace(0, 1, N),
"causal effect": 10 * gamma(10).pdf(np.arange(0, N, 1) - treatment_time),
}
)

Expand All @@ -147,7 +147,9 @@ def generate_time_series_data(
for var in ["deaths_actual", "temperature"]:
df[var] += norm(0, 0.1).rvs(N)

# add intercept
# add intercept column of ones (for modeling purposes)
# This is correctly a column of ones, not beta_intercept, as beta_intercept
# is already incorporated in the data generation above
df["intercept"] = np.ones(df.shape[0])

return df
Expand Down