-
Notifications
You must be signed in to change notification settings - Fork 88
Add variable selection priors #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NathanielF
wants to merge
27
commits into
pymc-labs:main
Choose a base branch
from
NathanielF:vs_module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1f4f695
adding vs module
NathanielF 2a01933
Merge branch 'main' into vs_module
NathanielF db1e81d
adding demo notebook
NathanielF db0522e
trying to fix doctests
NathanielF 1670af4
adding fix
NathanielF 83061e4
another fix
NathanielF 05dc20d
update fix
NathanielF 73e6a8d
adding tests
NathanielF 8d6251f
update adding more tests
NathanielF 4577106
add normal test vs_prior
NathanielF fd1bfb7
improving test coverage
NathanielF 7375aa5
updating notebook
NathanielF 896ee57
update index
NathanielF 1bb79d3
Merge branch 'main' into vs_module
NathanielF 068c922
update spelling
NathanielF 13b320e
add binary treatment case to IV model
NathanielF 6210116
adding more write up
NathanielF bf5b404
update heading
NathanielF b16ef30
hide cells
NathanielF b88271e
better story telling
NathanielF c452650
tidying
NathanielF a5dd60f
hide cell inputs
NathanielF 2578cce
Merge branch 'main' into vs_module
NathanielF a7c1090
fixing linting
NathanielF 78ed0ce
fix linting error
NathanielF 9e6ede0
update typing
NathanielF dbc8614
spell check
NathanielF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,4 +41,5 @@ | |
| "RegressionKink", | ||
| "skl_models", | ||
| "SyntheticControl", | ||
| "variable_selection_priors", | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Validation warning ignores binary_treatment flag setting
The
input_validationmethod checks if the treatment variable has more than 2 unique values and warns that "We will use the multivariate normal likelihood for continuous treatment." However, this warning doesn't account for the newbinary_treatmentparameter. If a user setsbinary_treatment=Truewhile having continuous treatment data, the warning incorrectly suggests MVN will be used, when actually the Bernoulli likelihood will be applied (which would fail on non-binary data). The validation needs to cross-check the actual data against theself.binary_treatmentflag.