Skip to content

Add CLVWrapper #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add CLVWrapper #1377

wants to merge 4 commits into from

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented Jan 15, 2025

Description

Building upon CLV MLflow integration. WIP

CC: @ColtAllen

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV
  • Customer Choice

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1377.org.readthedocs.build/en/1377/

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@492930a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymc_marketing/mlflow.py 42.85% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage        ?   92.15%           
=======================================
  Files           ?       64           
  Lines           ?     7448           
  Branches        ?        0           
=======================================
  Hits            ?     6864           
  Misses          ?      584           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@williambdean
Copy link
Contributor Author

General question for @ColtAllen

Are you using the save load much? What do you do after loading?

@ColtAllen
Copy link
Collaborator

ColtAllen commented Jan 18, 2025

General question for @ColtAllen

Are you using the save load much? What do you do after loading?

I did monthly model runs at my last company. With about 1.5 million customers the idata file was about 500MB, hence the need for #1356. Before loading a model, metrics and number of new customers were checked first to see if retraining was needed. Otherwise, run & rewrite predictions.

@williambdean williambdean added CLV enhancement New feature or request labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV enhancement New feature or request mlflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants