Skip to content

Fix test to suppress warning on allocate_budget_to_maximize_response #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix test to suppress warning on allocate_budget_to_maximize_response #1603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b39ddd
Fix test to suppress warning on allocate_budget_to_maximize_response
caiquefortunato Mar 29, 2025
4c7b5a4
Merge branch 'main' into fix/test-warning-allocation
cetagostini Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions tests/mmm/test_mmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import pymc as pm
import pytest
import xarray as xr
import warnings
from matplotlib import pyplot as plt

from pymc_marketing.mmm.budget_optimizer import optimizer_xarray_builder
Expand Down Expand Up @@ -580,13 +581,15 @@ def test_allocate_budget_to_maximize_response_bad_noise_level(
noise_level = "bad_noise_level"

with pytest.raises(ValueError, match="noise_level must be a float"):
mmm_fitted.allocate_budget_to_maximize_response(
budget=budget,
time_granularity=time_granularity,
num_periods=num_periods,
budget_bounds=budget_bounds,
noise_level=noise_level,
)
with warnings.catch_warnings():
warnings.simplefilter("ignore")
mmm_fitted.allocate_budget_to_maximize_response(
budget=budget,
time_granularity=time_granularity,
num_periods=num_periods,
budget_bounds=budget_bounds,
noise_level=noise_level,
)

@pytest.mark.parametrize(
argnames="original_scale",
Expand Down