-
Notifications
You must be signed in to change notification settings - Fork 326
Add Example Gallery #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Example Gallery #1611
Conversation
|
Are thumbnails required? What happens if one isnt included? |
|
This is great! Is there no NB on geo? |
There is! MMM Multidimensional Example Notebook :) |
|
Should we give that a better name? |
init fix galery layout lower case
delete images from repo try fix error try gix error try fix error update git ignore
|
This looks awesome. Do you know if "Section Navigation" on the left side can be removed. It is currently empty |
Specifically Geo MMM Example? What do you have in mind? |
|
The dependency issue is independent of this PR, it seems as other builds are failing https://app.readthedocs.org/projects/pymc-marketing/builds/27719823/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 55 55
Lines 6357 6357
=======================================
Hits 5946 5946
Misses 411 411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The "How-to" is now pushed into the "More" dropdown menu. At least with my screen size. Maybe we can link at the top of the Gallery section. Or specify that these are all the same notebooks, just different way to organize them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this looks great.
What is the process for adding a new notebook now? Can we outline that and raise if we can detect?
I think the workflow is very similar as before: add the notebook into the notebooks folder and add it in gallery.md (instead of howto.md) |
You didn't like the auto-generated gallery the other script did? |
|
Oh! I need to double-check! I kind of wanted to have the freedom to define the gallery structure but ill revise it 👀 |
|
I will tackle this in a following PR, see the issue #1617 . The current notebook list is just very ugly, so let's work on iterations 🙏 |
Anything that makes someone that is looking for Geo MMM click on that NB. I just think multi-dimensional is not that. Whether that's a rename or new NB with that name. |
|
Is howto superseded by this? In that case I think we should consider just removing it. |
Would the previous links still work? Would that break any references in social posts? |
It is now removed |
I think so, still, I had gotten feedback that it was not clear for many people that "howto" contained the example notetbooks. |
|
@twiecki I added some info regarding geo-mmm It is not the main title, as many users are using other types of dimensions (e.g., outlets) |
|
@williambdean can we merge this one? 🙏 |
Let's do it! |

Add an example gallery to harmonize the example layout in PyMC and Pytensor. I followed pymc-devs/pytensor#1150 from @jessegrabowski (thank you!) and some help from Sonnet ;)
I also added some subsections for the MMM docs to make it easy to access the material.
This is a snapshot:
📚 Documentation preview 📚: https://pymc-marketing--1611.org.readthedocs.build/en/1611/