Skip to content

Get marginal_effects hdi estimates #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Aug 13, 2025

Description

counterfac = self.mmm.predict(X_new, extend_idata=False, progressbar=False) internally calls mean("chain", "draws") which inhibits hdi calculations.

We are now calling sample_posterior_predictive, which includes ("chain", "draw") dims

Related Issue

  • Closes #
  • Related to #

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Aug 13, 2025
@PabloRoque PabloRoque marked this pull request as ready for review August 13, 2025 10:30
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.88%. Comparing base (be685bd) to head (483af3e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files          64       64              
  Lines        7563     7562       -1     
==========================================
- Hits         6949     6948       -1     
  Misses        614      614              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the tests label Aug 13, 2025
@juanitorduz juanitorduz merged commit 4631ba1 into pymc-labs:main Aug 14, 2025
31 checks passed
@juanitorduz
Copy link
Collaborator

thank you @PabloRoque !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants