Skip to content

Custom MMM Model: ROAS Parametrization#2361

Open
juanitorduz wants to merge 7 commits intomainfrom
mmm_roas_parametrization
Open

Custom MMM Model: ROAS Parametrization#2361
juanitorduz wants to merge 7 commits intomainfrom
mmm_roas_parametrization

Conversation

@juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Mar 3, 2026

Custom ROAS parametrization module using pymc-marketing. Port of the extensive simulation study: https://juanitorduz.github.io/mmm_roas/ by @juanitorduz


📚 Documentation preview 📚: https://pymc-marketing--2361.org.readthedocs.build/en/2361/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz self-assigned this Mar 3, 2026
@juanitorduz juanitorduz marked this pull request as draft March 3, 2026 14:55
@github-actions github-actions bot added docs Improvements or additions to documentation MMM labels Mar 3, 2026
@juanitorduz juanitorduz marked this pull request as ready for review March 4, 2026 16:41
@cursor
Copy link
Contributor

cursor bot commented Mar 4, 2026

PR Summary

Low Risk
Low risk documentation-only change that updates the example gallery navigation; main impact is potential broken links/images if referenced assets are missing.

Overview
Adds a new Custom Models gallery card linking to the mmm_roas_parametrization notebook (with a corresponding thumbnail image), and standardizes the section heading capitalization from "Custom models" to "Custom Models".

Written by Cursor Bugbot for commit 1fa8ef8. This will update automatically on new commits. Configure here.

@review-notebook-app
Copy link

review-notebook-app bot commented Mar 4, 2026

View / edit / reply to this conversation on ReviewNB

williambdean commented on 2026-03-04T19:48:13Z
----------------------------------------------------------------

Can we address this deprecation :

var/folders/cm/3dzy9rdd5s3672z0s1brjkvh0000gn/T/ipykernel_87557/4038080168.py:16: FutureWarning: find_constrained_prior is deprecated and will be removed in a future version. Please use maxent function from PreliZ. https://preliz.readthedocs.io/en/latest/api_reference.html#preliz.unidimensional.maxent

ls_params = pm.find_constrained_prior(


juanitorduz commented on 2026-03-04T22:16:02Z
----------------------------------------------------------------

Fixed :)

Copy link
Collaborator Author

Fixed :)


View entire conversation on ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation MMM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant