Skip to content

Fix monitoring of functions #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 2 commits into from
Dec 11, 2025
Merged

Fix monitoring of functions #2826

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f91c7f1
Fix monitoring of functions
alexrudd2 Dec 8, 2025
84818a0
Merge branch 'dev' into http-monitor
janiversen Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymodbus/server/simulator/http_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,10 @@ def build_html_calls(self, params: dict, html: str) -> str: # pragma: no cover
for function in DecodePDU(True).list_function_codes():
selected = (
"selected"
if function.function_code == self.call_monitor.function
if function == self.call_monitor.function
Copy link
Collaborator

@janiversen janiversen Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong, it is a list of function codes, not object pointers.

else ""
)
function_codes += f"<option value={function.function_code} {selected}>function code name</option>"
function_codes += f"<option value={function} {selected}>function code name</option>"
Copy link
Collaborator

@janiversen janiversen Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, you are now building a list of object pointers and not function codes !

simulation_action = (
"ACTIVE" if self.call_response.active != RESPONSE_INACTIVE else ""
)
Expand Down