Fixed MD links attached to the right span instead of the whole sentence#174
Open
DiazBejaranoD wants to merge 1 commit intopymupdf:mainfrom
Open
Fixed MD links attached to the right span instead of the whole sentence#174DiazBejaranoD wants to merge 1 commit intopymupdf:mainfrom
DiazBejaranoD wants to merge 1 commit intopymupdf:mainfrom
Conversation
|
Hello, using your method found that char_index_max causes the array to cross bounds, and char_index_max keeps decreasing <0 until it exceeds the text length |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
Expanded resolve_links feature to allow the correct span of text to be used in the MD link.
In v0.0.17, the whole sentence is used as the link text.
Limitations: