Add license file to package source and specify min python version#290
Add license file to package source and specify min python version#290nmohr192 wants to merge 1 commit intopymupdf:mainfrom
Conversation
|
@JorjMcKie Could you please have a look? |
|
We do welcome your intention to make the package available to conda. PyMuPDF4LLM - like most other Artifex products - is double-licensed under either GNU AFFERO GPL 3.0 or commercial licenses. I will need to find a way to express this condition in the package and include the license file. The next version 0.0.26 should be fine in that respect. As per the supported Python versions, this is identical to what PyMuPDF itself does: We are supporting all Python versions that are actively maintained by the PSF (Python Software Foundation) at any point in time. |
|
Once version 0.0.26 is on PyPI I will close this PR. Thanks again for contributing it and considering PyMuPDF4LLM! |
|
Hi Jorj, thanks for your response. If you close this PR, then please ensure the License is part of the tarball release to pypi for the conda recipe integration, and the minimum python version is mentioned at least in the setup.py for your 0.0.26 release. Thanks |
|
Sure - I have local wheel and tarball files that look good. |
|
Sounds good, thanks :) I am aware of this (see my PR in the conda repo here). It's a bit unfortunate, that conda-forge only offers linux version for pymupdf, even though it's noarch on pypi. This means that pymupdf4llm can also only be published as linux only to conda-forge, or I also have to create a PR for updating pymupdf on conda-forge. |
I am planning to sync this package as a recipe to conda forge to install it in my conda envs, but to finalize this PR I need the tarball to contain the LICENSE file and the package to specify a minimum python version.
Please review and release to pypi! :)