Skip to content

Verify flash contents after programming #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Verify flash contents after programming #1702

wants to merge 2 commits into from

Conversation

nattgris
Copy link
Contributor

Add an option, on by default, to read out flash contents after programming and compare it to the programmed data. Without it, bugs in flash loader algos and other problems will silently leave flash corrupted.

Ref: #1700, #1696

@nattgris nattgris changed the base branch from main to develop June 13, 2024 09:50
@nattgris
Copy link
Contributor Author

Sorry, should pull-requests be based on develop or main?

@ithinuel
Copy link
Member

develop is 28commits behind main (ie there are 28 extra commits on main) so I'd assume main to be the main target branch (I'm not 100% sure though).

@nattgris nattgris changed the base branch from develop to main December 3, 2024 17:03
ithinuel
ithinuel requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thank you for your contribution.

I think there should be some tests added to make sure that it does capture cases where things don't match and possible future regression.

@nattgris
Copy link
Contributor Author

nattgris commented Aug 4, 2025

I think there should be some tests added to make sure that it does capture cases where things don't match and possible future regression.

I unfortunately have no idea how those tests could be written. I did test manually using the broken flash driver mentioned in the referenced issues.

@nattgris
Verify flash contents after programming
064de36 
Add an option, on by default, to read out flash contents after
programming and compare it to the programmed data. Without it, bugs in
flash loader algos and other problems will silently leave flash
corrupted.
@nattgris nattgris requested a review from ithinuel August 5, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ithinuel ithinuel Awaiting requested review from ithinuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattgris @ithinuel