Add support for constraints, install in topological order#177
Closed
bollwyvl wants to merge 17 commits intopyodide:mainfrom
Closed
Add support for constraints, install in topological order#177bollwyvl wants to merge 17 commits intopyodide:mainfrom
bollwyvl wants to merge 17 commits intopyodide:mainfrom
Conversation
Member
|
Looks nice so far I suppose the next step would be to actually use them. |
846ed37 to
e50f58c
Compare
for more information, see https://pre-commit.ci
ryanking13
reviewed
Jan 25, 2025
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks! I left some comment
Contributor
Author
|
Had a thought which might skip all the bookkeeping: still do |
7 tasks
Contributor
Author
|
I think #181 is the better way forward, but will keep this open as a draft for reference. |
Member
|
Closing in favor of #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references
changes
micropip.set_constraintsconstraintsto the signatures ofinstallandTransactioninstallto handle constrained indirect dependencies of packages found inpyodide-lock.jsonrequested_byto the signatures of manyTransactionmethodsTransaction.dependency_graphbreaking changes
hopefully none, as it's opt-in, and only adds keyword-only arguments to the already very finickyinstall, etc.pyodide-lock.jsonwere unconditionally installed before any resolved wheels