Skip to content

Conversation

agriyakhetarpal
Copy link
Member

Description

This PR adds usage and installation instructions with pip, global installation and usage instructions with pipx and uvx, and some general recommendations.

This is mainly because I have these saved in my notes, which I have trouble finding at times – and the README could serve as a more permanent place for them until we have the documentation up and hosted.

Related to #54 and #58

README.md Outdated
### Usage

> [!TIP]
> Currently, installing `pyodide-build` is preferred to running it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? I usually don't have the question "should I install this or should I run it" because usually I have to install first in order to run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I meant to convey that users are better off installing pyodide-build (globally or in a virtual environment) rather than trying to use pipx or uvx (instructions for which are provided for completeness). I'll try to reword this sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope 3ec2ab2 conveys the meaning better!

README.md Outdated
Comment on lines 40 to 42
> [!NOTE]
> If installing `pyodide-build` and its dependencies in virtual environments, we recommend
using ones that are managed by `venv` or `virtualenv` at the moment; see #58.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!NOTE]
> If installing `pyodide-build` and its dependencies in virtual environments, we recommend
using ones that are managed by `venv` or `virtualenv` at the moment; see #58.
> [!NOTE]
> Currently `pyodide-build` does not work well in environments managed by uv, see #58.

I think this is the only thing in this PR that is appropriate for a readme. I think this adds a lot of noise, people can use pipx or uvx or venv or install pyodide-build globally or use whatever tools as they prefer. The readme isn't a tutorial on Python installer workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@agriyakhetarpal
Copy link
Member Author

One reason we could keep the global installation instructions is that they are used quite often in CI environments; pipx is used internally by GitHub actions to manage tooling and comes installed by default on GitHub runners.

Considering that pyodide-build doesn't provide a CLI of its own (which comes from pyodide-cli) and the custom [pipx.run] section can't help with this, it's not straightforward how to use it with such tools.

I can remove the unneeded bits, though. WDYT?

@agriyakhetarpal agriyakhetarpal mentioned this pull request Mar 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants